Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Peer AKS VNet (mgmt) with VM based default templates #5288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Nov 19, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • This PR updates the templates (based off of VMs) to use private IP of the API Server of the control plane of the workload cluster for inter-node communication.
  • This PR also updates the Tiltfile with logic to peer AKS VNets with workload cluster's VNets.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #5261

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update VM based templates to use Private IP solution for workload cluster's inter-node communication. Also update Tiltfile to update AKS Vnet with workload cluster's VNet

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nawazkh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2024
@nawazkh nawazkh force-pushed the peer-aks-vnet-with-in-tiltfile branch from d24a789 to dd27c47 Compare November 19, 2024 00:56
@nawazkh nawazkh marked this pull request as ready for review November 19, 2024 00:56
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (6bc2cab) to head (3025950).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5288      +/-   ##
==========================================
+ Coverage   52.52%   52.57%   +0.04%     
==========================================
  Files         272      272              
  Lines       29433    29408      -25     
==========================================
+ Hits        15461    15462       +1     
+ Misses      13169    13148      -21     
+ Partials      803      798       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

- update aks-as-mgmt scripts with VNet creation and all clusters deletion
- update default template
- update default aad
- update azure-bastion templates
- update azure-cni-v1 templates
- update edgezone templates
- update ephemeral templates
- update private templates
- update flatcar templates
- update nvdia-gpu templates
@nawazkh nawazkh force-pushed the peer-aks-vnet-with-in-tiltfile branch from cbba70f to 3025950 Compare November 19, 2024 22:53
Comment on lines +215 to +216
if settings.get("container_args"):
capz_container_args = settings.get("container_args").get("capz-controller-manager")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have often struggled in getting more logs outputted while running in tilt.
With this change, if we add the below yaml fields to our tilt-settings.yaml, we will can play around with more logging

container_args:
  capz-controller-manager:
    - "--v=2"

@nawazkh
Copy link
Member Author

nawazkh commented Nov 19, 2024

link checker is complaining about a deprecated module. Will follow up with another PR to fix it.

(node:1306) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
FILE: ./CHANGELOG/v1.14.5.md
4 links checked.

Unrelated, but this PR seems to be blocked on Windows conformance jobs.
Otherwise open for final review

@nawazkh
Copy link
Member Author

nawazkh commented Nov 20, 2024

/retest

@nawazkh
Copy link
Member Author

nawazkh commented Nov 22, 2024

this PR needs to be held for feature flag for ILB can be added.
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants