🐛 Disable aggregation of not reported MachinePool conditions for Cluster #11416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
59 tasks
|
/hold to verify YAMLs from CI |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-e2e-main |
|
/assign @fabriziopandini |
sbueringer
force-pushed
the
pr-disable-machinepool-aggregation
branch
from
c98cb6d
to
c2be5c2
Compare
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-disable-machinepool-aggregation
branch
from
c2be5c2
to
61d2f8a
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 820a55fd105bede6faafe82fc8572a3f0d0dd98c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Currently the conditions on Cluster level are showing a lot of errors as soon as MachinePools are used, because conditions are not yet implemented for MachinePools.
This PRs temporariliy stops aggregating conditions from MachinePools and MachinePool Machines to end up with a clean status on the Cluster resource. This PR can be reverted once the conditions are implemented on MachinePools and MachinePool Machines.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11105