Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change env IMAGE to KNP_IMAGE for build image. #73

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Aug 8, 2024

releated #70

#19 ERROR: failed to push gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://gcr.io/v2/token?scope=repository%3Ak8s-staging-test-infra%2Fgcb-docker-gcloud%3Apull%2Cpush&service=gcr.io: 403 Forbidden

stil failing post the build image, the reason is there is an IMG gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36 environment variable by default. This causes kube-network-policies to be pushed to the wrong image repository when building the image.

kube-network-policies$ docker inspect gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36|grep IMAGE
                "IMAGE=gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36",

see https://github.com/kubernetes/test-infra/blob/c3c3ae29e0eca28eb4349a99d5605beb0103f1b7/images/gcb-docker-gcloud/Dockerfile#L24

so this PR is working for change the environment IMAGE to KNP_IMAGE, i think it can resolve it. But if there is any way to use prowjob to test ahead of time based on this PR, that would be great

@k8s-ci-robot k8s-ci-robot requested review from aojea and thockin August 8, 2024 04:24
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2024
@@ -5,4 +5,7 @@ options:
steps:
- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36
entrypoint: make
env:
- REGISTRY=gcr.io/k8s-staging-networking
- IMAGE_NAME=kube-network-policies
args: ['release']
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we need to get gcloud auth for docker image here?, just like gcloud auth configure-docker

cc @ameukam , thank you!

see https://github.com/kubernetes-sigs/kwok/blob/2033297e7e4bb3068b1d8ef4d240f9decab0663c/cloudbuild.yaml#L23

@aojea
Copy link
Contributor

aojea commented Aug 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2024
@aojea
Copy link
Contributor

aojea commented Aug 16, 2024

/lgtm
/approve

Let's iterate

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 62e6a5b into kubernetes-sigs:main Aug 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants