-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change env IMAGE to KNP_IMAGE for build image. #73
chore: change env IMAGE to KNP_IMAGE for build image. #73
Conversation
Signed-off-by: Lan Liang <[email protected]>
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -5,4 +5,7 @@ options: | |||
steps: | |||
- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36 | |||
entrypoint: make | |||
env: | |||
- REGISTRY=gcr.io/k8s-staging-networking | |||
- IMAGE_NAME=kube-network-policies | |||
args: ['release'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do we need to get gcloud auth for docker image here?, just like gcloud auth configure-docker
cc @ameukam , thank you!
/ok-to-test |
/lgtm Let's iterate |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
releated #70
stil failing post the build image, the reason is there is an IMG
gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36
environment variable by default. This causeskube-network-policies
to be pushed to the wrong image repository when building the image.see https://github.com/kubernetes/test-infra/blob/c3c3ae29e0eca28eb4349a99d5605beb0103f1b7/images/gcb-docker-gcloud/Dockerfile#L24
so this PR is working for change the environment IMAGE to
KNP_IMAGE
, i think it can resolve it. But if there is any way to use prowjob to test ahead of time based on this PR, that would be great