-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preflight network resource support for custom_cni #11432
base: master
Are you sure you want to change the base?
Add preflight network resource support for custom_cni #11432
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HoKim98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @HoKim98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
--- | ||
- name: Custom CNI | Preflight | Start Resources | ||
kube: | ||
namespace: "kube-system" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the namespace also set to kube-system in other cni/network plugin deployments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the namespace is definitely not appropriate. Therefore, I have modified and rebased the code to allow setting the namespace in the ".namespace" format! However, generally, CNIs are deployed in the kube-system namespace. Thus, if the namespace is not specified, I have adjusted it to use kube-system
as the default.
/ok-to-test |
I think it's a nice feature, but I don't think it needs to be limited to |
d3d38c8
to
155fb83
Compare
I agree that using the CNI deployment method managed by Kubespray, as in the case of custom_cni, would be convenient for users. However, I am concerned that this might prevent the development of pre-deployment features that many might need, by providing a new workaround for users to solve issues themselves instead of reporting them to the community. If this concern of mine is unfounded (or not something I should worry about), I am willing to modify the code to apply it to all CNIs! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
PR Type
/kind feature
What this PR Does / Why We Need It
Which Issue(s) this PR Fixes
Fixes #
Special Notes for Your Reviewer
I want to enable the serviceMonitor option when installing Cilium CNI as custom_cni. However, I couldn't find a way to deploy the ServiceMonitor CRD prior to CNI installation. So I want to add a feature to deploy the prerequisite resources that should be deployed before the CNI during the custom_cni deployment process.
Additionally, I have prepared a new PR to enable pre-deployment of Ansible Roles if the pre-deployment feature for resources is merged in any form (custom_cni, generic, ...). This was necessary because while deploying Cilium CNI, I encountered an issue where the deployment of hubble-relay failed due to CoreDNS not being active when the peer service was enabled on cilium-agent. This PR aims to address that problem.
Does this PR Introduce a User-Facing Change?
No, this new method is managed by new variable
custom_cni_preflight_templates
.