fix: always restart logs aggregator #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
leoporoli
approved these changes
Nov 22, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.35](0.85.34...0.85.35) (2023-11-22) ### Features * upgrade golang grpc dependency ([#1840](#1840)) ([2377868](2377868)) ### Bug Fixes * always restart logs aggregator ([#1841](#1841)) ([7e6382f](7e6382f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change strengthens the restart policy for the logs aggregator. Prior to this, the restart only occurred on failure. Now, we make docker attempt to always restart the logs aggregator. This should help address #1832 where the logs aggregator was stopped with a
137status code but wasn't restarted.This change also addresses a
Propagate must be provided with a causepanic occurred here: #1832. This was caused by nil err's being propagated in the create logs collector code. This change fixes that issue.Is this change user facing?
NO
References:
#1832
#1311