fix: always restart logs aggregator

container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend.go

@@ -415,14 +415,14 @@ func (backend *DockerKurtosisBackend) CreateLogsCollectorForEnclave(
 	if maybeLogsAggregator == nil {
 		logrus.Warnf("Logs aggregator container does not exist. This is unexpected as docker should have restarted the container automatically.")
 		logrus.Warnf("This can be fixed by restarting the engine using `kurtosis engine restart` and attempting to create the enclave again.")
-		return nil, stacktrace.Propagate(err, "No logs aggregator container exists. The logs collector cannot be run without a logs aggregator.")
+		return nil, stacktrace.NewError("No logs aggregator container exists. The logs collector cannot be run without a logs aggregator.")
 	}
 	if maybeLogsAggregator.GetStatus() != container.ContainerStatus_Running {
 		logrus.Warnf("Logs aggregator exists but is not running. Instead container status is '%v'. This is unexpected as docker should have restarted the container automatically.",
 			maybeLogsAggregator.GetStatus())
 		logrus.Warnf("This can be fixed by restarting the engine using `kurtosis engine restart` and attempting to create the enclave again.")
-		return nil, stacktrace.Propagate(err,
-			"The logs aggregator container exists but is not running. Instead container status is '%v'. The logs collector cannot be run without a logs aggregator.",
+		return nil, stacktrace.NewError(
+			"The logs aggregator container exists but is not running. Instead logs aggregator container status is '%v'. The logs collector cannot be run without a logs aggregator.",
 			maybeLogsAggregator.GetStatus(),
 		)
 	}

container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/logs_aggregator_functions/implementations/vector/vector_container_config_provider.go

@@ -54,7 +54,7 @@ func (vector *vectorContainerConfigProvider) GetContainerArgs(
 
 	// The logs aggregator should ALWAYS be running to ensure that no logs are lost for services in enclaves
 	// Thus, instruct docker to restart the container if it exits with non-zero status code for whatever reason
-	restartPolicy := docker_manager.RestartPolicy("on-failure")
+	restartPolicy := docker_manager.RestartPolicy(docker_manager.RestartAlways)
 
 	createAndStartArgs := docker_manager.NewCreateAndStartContainerArgsBuilder(
 		containerImage,

container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go

@@ -142,6 +142,7 @@ const (
 type RestartPolicy string
 
 const (
+	RestartAlways    = "always"
 	RestartOnFailure = "on-failure"
 	NoRestart        = ""
 )