-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: persistent volumes work on multi node k8s clusters #1943
Conversation
TODO
|
Deploying with Cloudflare Pages
|
## Description: Introduces the ability to have persistent directories of a given size using `size` ## Is this change user facing? YES
c824d9e
to
3e912df
Compare
...pls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/persistent_directories.go
Show resolved
Hide resolved
...pls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/persistent_directories.go
Show resolved
Hide resolved
...pls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/persistent_directories.go
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Outdated
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with some comments. The most important is the one related to waiting for pv binding
is it not necessary to know that the cluster provider creates the PV? or how Kurtosis detects that the cluster provider (DO, for instance) creates the PV?
@h4ck3rk3y I think if users run |
🤖 I have created a release *beep* *boop* --- ## [0.85.49](0.85.48...0.85.49) (2023-12-18) ### Features * add production mode to k8s ([#1963](#1963)) ([b0e27e6](b0e27e6)) * persistent volumes work on multi node k8s clusters ([#1943](#1943)) ([b2fd9f2](b2fd9f2)) * User service K8S ingresses for reverse proxy routing ([#1941](#1941)) ([c37dd7f](c37dd7f)) ### Bug Fixes * adding remove logs aggregator container function when it already exists ([#1974](#1974)) ([5d74d16](5d74d16)) * Do not fail if the Traefik config dir path already exists ([#1966](#1966)) ([4e6f7d7](4e6f7d7)) * ignore the current status of the service during a start/stop ([#1965](#1965)) ([1c4863f](1c4863f)) * refactor the emui components to the shared package ([#1959](#1959)) ([a406973](a406973)) * Set the user service K8S ingress labels so it can be found ([#1962](#1962)) ([9cc5f77](9cc5f77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: leoporoli <[email protected]>
feat: use storage-class in the kurtosis-config.yaml; users should make sure that they have the right storage class configured in their
kurtosis-config.yaml