Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner - enable oidc extension by default for newly provisioned clusters #3467

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Sep 3, 2024

Enabling OIDC extension for Provisioned shoots by adding following item to list of shoot extensions

extensions:
   - type: shoot-oidc-service  #this line enables OIDC extension
     disabled: false

This change will affect only new clusters as specified in #3466

Extension section from test shoot provisioned on AWS

extensions:
  - type: shoot-dns-service
    providerConfig:
      apiVersion: some-version
      dnsProviderReplication:
        enabled: true
      kind: DNSConfig
      providers:
        - domains:
            include:
              - some-domain
          secretName: some-name
          type: some-type
      syncProvidersFromShootSpecDNS: true
  - type: shoot-cert-service
    providerConfig:
      apiVersion: some-api-version
      shootIssuers:
        enabled: true
      kind: CertConfig
  - type: shoot-networking-filter
    disabled: true
  - type: shoot-oidc-service
    disabled: false
  - type: shoot-auditlog-service
    providerConfig:
      kind: AuditlogConfig
      apiVersion: some-api-version
      type: standard
      tenantID: some-tenant
      serviceURL: some-url
      secretReferenceName: some-name

@koala7659 koala7659 requested a review from a team as a code owner September 3, 2024 11:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@koala7659 koala7659 force-pushed the provisioner-enable-oidc branch from 48b3698 to 8fa01af Compare September 3, 2024 11:05
@koala7659 koala7659 changed the title Enable oidc extension by default for newly provisioned clusters Provisioner - enable oidc extension by default for newly provisioned clusters Sep 3, 2024
@koala7659 koala7659 self-assigned this Sep 3, 2024
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@kyma-bot kyma-bot merged commit 8152ffd into kyma-project:main Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants