Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional label consumer name on dispatching metrics #217

Merged
merged 1 commit into from
Nov 13, 2023
Merged

add additional label consumer name on dispatching metrics #217

merged 1 commit into from
Nov 13, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Nov 6, 2023

Description

Changes proposed in this pull request:

  • add additional label 'consumer_name' onto metrics

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@kyma-bot
Copy link

kyma-bot commented Nov 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2023
@k15r k15r marked this pull request as ready for review November 9, 2023 13:09
@k15r k15r requested a review from a team as a code owner November 9, 2023 13:09
@k15r k15r requested a review from mfaizanse November 9, 2023 13:09
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2023
@muralov muralov force-pushed the add-consumer-name-to-metrics branch from 5d3158e to f0a63d9 Compare November 13, 2023 10:38
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2023
@kyma-bot kyma-bot merged commit a0a765b into kyma-project:main Nov 13, 2023
5 checks passed
@k15r k15r added this to the 1.0.1 milestone Nov 14, 2023
@k15r k15r linked an issue Nov 20, 2023 that may be closed by this pull request
include consumer name as label in eventing-manager metrics #208
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

include consumer name as label in eventing-manager metrics
3 participants
@k15r @kyma-bot @mfaizanse