[pull] main from microsoft:main #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* `[[nodiscard]]` and `[[maybe_unused]]` must come before `virtual` and `static` qualifiers * MSVC and Clang disagree on how `gsl::suppress` should look; fortunately, GSL provides a macro to paper over the difference * Clang throws "pessimizing move" warnings when you `std::move` a temporary, as it makes copy elision impossible * The fuzzing logic was using an unspecified template expansion `CFuzzLogic<>` before the type had been declared * LibraryResources was emitting most of the `.util` section with read-write permissions and some of it with read-only Refs #15952
This commit adds some styles to SettingContainer that can be used to display informational messages. They don't have reset buttons or content and they can't be interacted with. I did this because the InfoBars didn't scale properly when the window was wide. Also they had an [X] button that hid the warning but didn't persist that they had been hidden or anything.
I thought the Converters.idl file had a really neat ordering, and I felt like the .cpp implementation fell short of this. This PR reorders the functions in the implementation to match the IDL. It also gets rid of some unnecessary math (int vs. float, clamping) and removes another use of `std::stringstream` (= bad STL class).
Adds animations at the Entry and Exit of the Search Box. https://github.com/microsoft/terminal/assets/55626797/14773bb7-89d8-4dc4-9aa4-1600139e97ae Inspired by WinUI [CommandBarFlyout](https://github.com/microsoft/microsoft-ui-xaml/tree/v2.8.6/dev/CommandBarFlyout) ## Validation Steps Performed - Animation feels good ✅ - Works with multiple panes open. - Pane opening/closing doesn't cause re-animations.
## Summary of the Pull Request update to the latest cli11 version ## References and Relevant Issues none ## Detailed Description of the Pull Request / Additional comments none ## Validation Steps Performed ## PR Checklist - [ ] Closes #xxx - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) --------- Co-authored-by: Leonard Hecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )