-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved vpCircleHoughTransform #1290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Added a check to the magnitude of the gradient to avoid dividing by 0
…min > min_value due to pixelization
…me edge points + fix computation of radius bins
…[FIX] Fixed problems in the type of data in the circle candidates computation
… to give a clue to the vpCircleHoughTransform of how many different centers there are in the image. Still working on the merging phase of similar centers
…hanged the way the outputs of vpCircleHoughTransform are sorted
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
- Coverage 54.43% 54.27% -0.16%
==========================================
Files 400 400
Lines 50516 50658 +142
==========================================
Hits 27497 27497
- Misses 23019 23161 +142 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the vpCircleHoughTransform detection more stable
Improved the tutorial