Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved vpCircleHoughTransform #1290

Merged
merged 18 commits into from
Dec 8, 2023
Merged

Improved vpCircleHoughTransform #1290

merged 18 commits into from
Dec 8, 2023

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Dec 7, 2023

Made the vpCircleHoughTransform detection more stable
Improved the tutorial

rlagneau added 18 commits October 16, 2023 11:09
…tion. Added a check to the magnitude of the gradient to avoid dividing by 0
…me edge points + fix computation of radius bins
…[FIX] Fixed problems in the type of data in the circle candidates computation
… to give a clue to the vpCircleHoughTransform of how many different centers there are in the image. Still working on the merging phase of similar centers
…hanged the way the outputs of vpCircleHoughTransform are sorted
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 243 lines in your changes are missing coverage. Please review.

Comparison is base (35e3502) 54.43% compared to head (ad17d88) 54.27%.

Files Patch % Lines
modules/imgproc/src/vpCircleHoughTransform.cpp 0.00% 224 Missing ⚠️
...roc/include/visp3/imgproc/vpCircleHoughTransform.h 0.00% 18 Missing ⚠️
...odules/core/include/visp3/core/vpImageMorphology.h 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   54.43%   54.27%   -0.16%     
==========================================
  Files         400      400              
  Lines       50516    50658     +142     
==========================================
  Hits        27497    27497              
- Misses      23019    23161     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit dcfe00a into lagadic:master Dec 8, 2023
52 checks passed
@rolalaro rolalaro deleted the fixCHT branch December 11, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants