Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tests for rotations and quaternions, found failing tests #1351

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Mar 15, 2024

  • Verify that operator= of vpQuaternionVector works as intended
  • Merge testQuaternion.cpp and testQuaternion2.cpp under the catch2 framework
  • Merge testRotation.cpp and testRotation2.cpp under the catch2 framework
  • Fix failing test. Adding more tests wrt to rotation representations and conversions highlighted an issue in converting from a vpRotationMatrix to a vpRzyxVector (see section "Conversion from and to rzyx vector" of the proposed testRotation.cpp)

This failing test results in :

Initialization vpRzyxVector 
64: 3.141592654
64: 2.094395102
64: 0.7853981634
64: From vpRzyxVector to vpRotationMatrix  
64: 0.5  -0.6123724357  -0.6123724357
64: -6.123233996e-17  -0.7071067812  0.7071067812
64: -0.8660254038  -0.3535533906  -0.3535533906
64: From vpRotationMatrix to vpRzyxVector 
64: rzyx(3,1) = [-1.224646799e-16
64: 1.047197551
64: -2.35619449]
64: Test fails: bad content

@fspindle fspindle merged commit 35884e7 into lagadic:master Mar 19, 2024
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants