-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unscented Kalman Filter in python #1411
Conversation
rolalaro
commented
May 22, 2024
•
edited
Loading
edited
- Added the non-linear complex example in Python
- Added the examples in Python documentation
- Predict can now be called several times in a row
- Fix documentation
…thon. Problem with Cholesky's inversion
…was due to numerical instability
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1411 +/- ##
==========================================
- Coverage 45.55% 44.44% -1.12%
==========================================
Files 1082 1082
Lines 109238 109248 +10
Branches 18658 18675 +17
==========================================
- Hits 49767 48552 -1215
- Misses 59471 60696 +1225 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! a few remaining things but nothing big ;)
for j in range(nbLandmarks): | ||
mean[(2*j)+1] = np.arctan2(sumSin[j], sumCos[j]) | ||
orientations = np.arctan2(sumSin, sumCos) | ||
mean[1::2] = orientations[0::1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can omit the [0::1]: this is the default behavior (start from, iterate until the end with a step of one)
such as v[0] = dist_0 ; v[1] = bearing_0; v[2] = dist_1 ; v[3] = bearing_1 ... | ||
|
||
@param[in] meas Measurement to which we must substract something. | ||
@param[in] toSubstract The something we must substract. | ||
:param meas Measurement to which we must substract something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be :param meas:
""" | ||
@brief Compute the commands realinp.sing a turn at constant linear velocity. | ||
Compute the commands realinp.sing a turn at constant linear velocity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be realising ;)
…did a mistake in previous commit