(feature): Benchmarking Poseidon #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocolwhisper
requested review from
schouhy,
ajgara and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 140 140
Lines 31393 31393
=======================================
Hits 29938 29938
Misses 1455 1455 ☔ View full report in Codecov by Sentry. |
|
Are these the expected results? Let me know if it's a bad implementation of the bench |
Oppen
approved these changes
Dec 7, 2023
Oppen
previously approved these changes
Dec 18, 2023
|
Hi :) , Can I get comments on this? |
MauroToscano
previously approved these changes
Jan 29, 2024
MauroToscano
approved these changes
Jan 29, 2024
diegokingston
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark for new Poseidon
Following the merge of PR #702 . I've added the benchmark using the new Poseidon implementation.
Type of change
Checklist