Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature for RLP encoding #92

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Fix signature for RLP encoding #92

merged 6 commits into from
Aug 29, 2023

Conversation

IAvecilla
Copy link
Contributor

@IAvecilla IAvecilla commented Aug 1, 2023

Trying to deploy in the new era-test-node, we discovered an issue related to the signature and the RLP encoding for the transaction. This PR fixes that error, enabling deployment in both local-setup (docker nodes) and the new memory node.

closes #97

@IAvecilla IAvecilla changed the title Fix signature in for RLP encoding Fix signature for RLP encoding Aug 1, 2023
@jpcenteno jpcenteno self-requested a review August 28, 2023 16:14
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #92 (b54a79f) into main (39f010b) will increase coverage by 0.23%.
Report is 3 commits behind head on main.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   83.02%   83.26%   +0.23%     
==========================================
  Files          13       13              
  Lines        3170     3167       -3     
==========================================
+ Hits         2632     2637       +5     
+ Misses        538      530       -8     
Files Changed Coverage Δ
src/zks_utils.rs 31.03% <ø> (ø)
src/zks_wallet/wallet.rs 85.40% <66.66%> (+0.14%) ⬆️
src/eip712/transaction_request.rs 92.85% <90.47%> (+3.03%) ⬆️
src/eip712/transaction.rs 83.40% <100.00%> (+0.64%) ⬆️
src/zks_provider/mod.rs 91.06% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jpcenteno jpcenteno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any new test. Did we had failing tests before these changes? In my opinion, bug fix PRs should include tests to ensure the bug does not happen again. This also provides the added value of providing a bug explanation for cases like this when we have to review a PR from a month ago.

src/zks_utils.rs Outdated Show resolved Hide resolved
src/eip712/transaction.rs Outdated Show resolved Hide resolved
src/eip712/transaction_request.rs Show resolved Hide resolved
@jpcenteno jpcenteno added the bug Something isn't working label Aug 28, 2023
@IAvecilla
Copy link
Contributor Author

In terms of testing for this particular pull request, this fix specifically addresses the deploy feature in the memory node. To test it, you can change the ERA_CHAIN_ID to match the one in the memory node and set the environment variable to correspond to the memory node's URL.

Looking ahead, the plan could involve either migrating this testing procedure to the memory node directly or creating two distinct test suites—one for working with the node in a Docker environment and the other for the memory node.

Copy link
Collaborator

@mationorato mationorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mationorato mationorato merged commit ae3afd8 into main Aug 29, 2023
@mationorato mationorato deleted the fix_rlp_encoding branch August 29, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix signature for RLP encoding
4 participants