-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signature for RLP encoding #92
Conversation
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 83.02% 83.26% +0.23%
==========================================
Files 13 13
Lines 3170 3167 -3
==========================================
+ Hits 2632 2637 +5
+ Misses 538 530 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any new test. Did we had failing tests before these changes? In my opinion, bug fix PRs should include tests to ensure the bug does not happen again. This also provides the added value of providing a bug explanation for cases like this when we have to review a PR from a month ago.
In terms of testing for this particular pull request, this fix specifically addresses the deploy feature in the memory node. To test it, you can change the ERA_CHAIN_ID to match the one in the memory node and set the environment variable to correspond to the memory node's URL. Looking ahead, the plan could involve either migrating this testing procedure to the memory node directly or creating two distinct test suites—one for working with the node in a Docker environment and the other for the memory node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trying to deploy in the new
era-test-node
, we discovered an issue related to the signature and the RLP encoding for the transaction. This PR fixes that error, enabling deployment in bothlocal-setup
(docker nodes) and the new memory node.closes #97