community/templates: ClickHouse Template #17247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: vector store
Thanks - have addressed the comments! |
|
@efriis does it seem ok now? |
|
@efriis gentle nudge on this - any chance we could have eyes on this for a merge? Thank you! |
efriis
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Hey @mneedham ! Two requests:
- can we split this into 2 PRs, one with upgrades to community implementation, and one with the template (the community implementation needs to be released before the template is usable)
- in the community PR, could you add some documentation of what these changes do? docstring on _schema
- some comments below
| @@ -72,7 +72,7 @@ class ClickhouseSettings(BaseSettings): | |||
| username: Optional[str] = None | |||
| password: Optional[str] = None | |||
|
|
|||
| index_type: str = "annoy" | |||
| index_type: Optional[str] = "annoy" | |||
There was a problem hiding this comment.
What is this supposed to do? I think this will have unintended consequences in some string substitution stuff lower in the file
| You'll also need to install ClickHouse: | ||
|
|
||
| ```bash | ||
| curl https://clickhouse.com/ | sh |
There was a problem hiding this comment.
this looks kinda wild but looks like you serve that script via curl!
|
|
||
| It utilizes Ollama the LLM, GPT4All for embeddings, and ClickHouse for the vectorstore. | ||
|
|
||
| The vectorstore is created in `chain.py` and by default indexes a [blog post about feature stores]([https://lilianweng.github.io/posts/2023-06-23-agent/](https://clickhouse.com/blog/powering-featurestores-with-clickhouse)) for question-answering. |
|
Closing until community updates make it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: A RAG template for ClickHouse. Also has a change to let users pass in
index_typeasNone.Twitter handle: @markhneedham