-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: ClickHouse: Make it possible to not specify a vector index #18381
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@@ -209,6 +199,41 @@ def __init__( | |||
self.client.command(f"SET allow_experimental_{self.config.index_type}_index=1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mneedham just confirming - I'm pretty sure this change turns this into self.client.command(f"SET allow_experimental_None_index=1")
unless I'm mistaken. This seems undesirable?
761533f
to
39cb90d
Compare
@efriis I think I'm handling the empty |
39cb90d
to
69fc31d
Compare
@efriis how do I get the build to run? I think I've fixed the lint issues that were there before. |
Fixing in #19527 In the future if you make PRs from a personal branch, can push directly to your PR branch! https://python.langchain.com/docs/contributing/faq#how-do-i-allow-maintainers-to-edit-my-pr |
Vector indexes in ClickHouse are experimental at the moment and can sometimes break/change behaviour. So this PR makes it possible to say that you don't want to specify an index type.
Any queries against the embedding column will be brute force/linear scan, but that gives reasonable performance for small-medium dataset sizes.
In the other PR (#17247), @efriis asked:
This makes
index_type
optional. I think I've defended against it beingNone
inside the_schema
function, which is where it's used. But let me know if you think I've missed somewhere else where it's used.