core[minor],langchain[patch]: Move base indexing interface and logic to core #20667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XXL
Closed
efriis
approved these changes
Apr 23, 2024
| from langchain_core.pydantic_v1 import root_validator | ||
| from langchain_core.vectorstores import VectorStore | ||
|
|
||
| from langchain.indexes.base import NAMESPACE_UUID, RecordManager | ||
| NAMESPACE_UUID = uuid.UUID(int=1984) |
There was a problem hiding this comment.
i know this is just a migration but a comment of what this is doing would be great
There was a problem hiding this comment.
might be worth keeping some form of the langchain ones here just to confirm we don't break anything for existing users for now (maybe with a note at top to remove test file for 0.2)
There was a problem hiding this comment.
Good catch, I think I meant to remove some of the unit tests but not all of them (duplicated coverage with test_indexing in core). I can revert for now and just keep the duplicated code
dosubot
bot
added
the
lgtm
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…to core (#20667) This PR moves the interface and the logic to core. The following changes to namespaces: `indexes` -> `indexing` `indexes._api` -> `indexing.api` Testing code is intentionally duplicated for now since it's testing different implementations of the record manager (in-memory vs. SQL). Common logic will need to be pulled out into the test client. A follow up PR will move the SQL based implementation outside of LangChain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the interface and the logic to core.
The following changes to namespaces:
indexes->indexingindexes._api->indexing.apiTesting code is intentionally duplicated for now since it's testing different
implementations of the record manager (in-memory vs. SQL).
Common logic will need to be pulled out into the test client.
A follow up PR will move the SQL based implementation outside of LangChain.