Remove druntime's libunwind dependency #4691
Conversation
|
FYI: this is one of the stumbling blocks when trying to statically link with musl libc |
JohanEngelen
force-pushed
the
rm_libunwind_dep
branch
from
8cf18cf to
5f2a2f3
Compare
tests/dmd/runnable/test17559.d
Outdated
| @@ -2,6 +2,7 @@ | |||
| // REQUIRED_ARGS(linux freebsd dragonflybsd): -L-export-dynamic | |||
| // LDC (required for Win32 and -O): REQUIRED_ARGS(windows32mscoff): -link-defaultlib-debug | |||
| // LDC (FreeBSD's libexecinfo apparently doesn't like elided frame pointers): REQUIRED_ARGS(freebsd): -link-defaultlib-debug -frame-pointer=all | |||
| // LDC (our _UnwindBacktrace implementation - for musl libc - requires this): REQUIRED_ARGS(linux): -link-defaultlib-debug | |||
There was a problem hiding this comment.
It'd be worthwhile to figure out what is causing the need for -link-defaultlib-debug on all these platforms. Perhaps we can solve this by preventing optimization (with magic UDA) of specific functions in druntime (or remove some other delta between optimized vs debug builds of specific functions).
There was a problem hiding this comment.
(make new issue for that?)
There was a problem hiding this comment.
Win32 backtraces are a catastrophe AFAIK, but I couldn't care less. For FreeBSD, it's the elided frame pointers as per the comment. For musl, no idea, but NOT testing the release variant for every Linux distro would IMO be a test regression.
There was a problem hiding this comment.
yeah...
add the complexity of musl-specific parameters?
There was a problem hiding this comment.
I don't know, that doesn't sound sexy at least. In the short term, I'd probably remove this test file for musl CI and file an issue, unless you wanna dig into the problem and try to fix it.
There was a problem hiding this comment.
Yeah I was already digging into it but it will cost more time than simple thing I tried. So let's remove it from CI, and file a separate issue to be solved in time.
There was a problem hiding this comment.
fixed it by running the tests manually for now
|
Please let me know if you wanna include this in v1.39, then I'll wait with the release. |
It would actually really be nice to get this in yes (minus the test change --> remove tests from musl CI for the time being). |
… code path as libexec-based backtracing.
JohanEngelen
force-pushed
the
rm_libunwind_dep
branch
from
916fff3 to
23e894a
Compare
JohanEngelen
force-pushed
the
rm_libunwind_dep
branch
from
23e894a to
dac29ff
Compare
…20758) Based on: * ldc-developers/ldc#4639 * ldc-developers/ldc#4691 Co-authored-by: Martin Kinkelin <[email protected]>
No description provided.