fix: Ledger - cancel properly and don't allow user to close non cancellable sections #5597
Annotations
8 errors, 2 warnings, and 1 notice
|
Run Playwright tests:
tests/specs/rpc-sign-psbt/sign-psbt.spec.ts#L24
1) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:88:3 › Sign PSBT › that only requested inputs are signed
Test timeout of 30000ms exceeded while running "beforeEach" hook.
22 |
23 | test.describe('Sign PSBT', () => {
> 24 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, page }) => {
| ^
25 | await globalPage.setupAndUseApiCalls(extensionId);
26 | await onboardingPage.signInWithTestAccount(extensionId);
27 | await page.goto('localhost:3000');
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:24:8
|
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L284
1) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:88:3 › Sign PSBT › that only requested inputs are signed
Error: locator.isVisible: Target page, context or browser has been closed
Call log:
- checking visibility of getByText('Enter your password')
at page-object-models/onboarding.page.ts:284
282 | */
283 | async signInWithTestAccount(id: string) {
> 284 | const isUnlockPage = async () => await this.page.getByText('Enter your password').isVisible();
| ^
285 | while (!(await isUnlockPage())) {
286 | await this.page.evaluate(
287 | async walletState => await chrome.storage.local.set({ 'persist:root': walletState }),
at isUnlockPage (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:284:87)
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:285:20)
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:26:5
|
|
Run Playwright tests:
tests/specs/rpc-sign-psbt/sign-psbt.spec.ts#L24
2) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:102:3 › Sign PSBT › that the request can be signed and broadcast
Test timeout of 30000ms exceeded while running "beforeEach" hook.
22 |
23 | test.describe('Sign PSBT', () => {
> 24 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, page }) => {
| ^
25 | await globalPage.setupAndUseApiCalls(extensionId);
26 | await onboardingPage.signInWithTestAccount(extensionId);
27 | await page.goto('localhost:3000');
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:24:8
|
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L286
2) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:102:3 › Sign PSBT › that the request can be signed and broadcast
Error: page.evaluate: Target page, context or browser has been closed
at page-object-models/onboarding.page.ts:286
284 | const isUnlockPage = async () => await this.page.getByText('Enter your password').isVisible();
285 | while (!(await isUnlockPage())) {
> 286 | await this.page.evaluate(
| ^
287 | async walletState => await chrome.storage.local.set({ 'persist:root': walletState }),
288 | testSoftwareAccountDefaultWalletState
289 | );
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:286:23)
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:26:5
|
|
Run Playwright tests:
tests/specs/rpc-sign-psbt/sign-psbt.spec.ts#L24
3) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:122:3 › Sign PSBT › that the request to sign can be canceled
Test timeout of 30000ms exceeded while running "beforeEach" hook.
22 |
23 | test.describe('Sign PSBT', () => {
> 24 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, page }) => {
| ^
25 | await globalPage.setupAndUseApiCalls(extensionId);
26 | await onboardingPage.signInWithTestAccount(extensionId);
27 | await page.goto('localhost:3000');
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:24:8
|
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L296
3) [chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:122:3 › Sign PSBT › that the request to sign can be canceled
Error: locator.waitFor: Target page, context or browser has been closed
Call log:
- waiting for locator('text="Account 1"') to be visible
at page-object-models/onboarding.page.ts:296
294 | await this.page.getByRole('button', { name: 'Continue' }).click();
295 | await this.page.waitForURL('**' + RouteUrls.Home);
> 296 | await this.page.locator('text="Account 1"').waitFor();
| ^
297 | }
298 |
299 | /**
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:296:49)
at /home/runner/work/extension/extension/tests/specs/rpc-sign-psbt/sign-psbt.spec.ts:26:5
|
|
Run Playwright tests:
tests/specs/send/send-btc.spec.ts#L12
4) [chromium] › specs/send/send-btc.spec.ts:32:5 › send btc › btc send form › that recipient input is trimmed correctly
Test timeout of 30000ms exceeded while running "beforeEach" hook.
10 |
11 | test.describe('send btc', () => {
> 12 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, sendPage }) => {
| ^
13 | await globalPage.setupAndUseApiCalls(extensionId);
14 | await onboardingPage.signInWithTestAccount(extensionId);
15 | await homePage.selectTestNet();
at /home/runner/work/extension/extension/tests/specs/send/send-btc.spec.ts:12:8
|
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
4) [chromium] › specs/send/send-btc.spec.ts:32:5 › send btc › btc send form › that recipient input is trimmed correctly
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/send/send-btc.spec.ts:14:5
|
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: nick-fields/retry@v2, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "all-blob-reports".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
|
Run Playwright tests
4 flaky
[chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:88:3 › Sign PSBT › that only requested inputs are signed
[chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:102:3 › Sign PSBT › that the request can be signed and broadcast
[chromium] › specs/rpc-sign-psbt/sign-psbt.spec.ts:122:3 › Sign PSBT › that the request to sign can be canceled
[chromium] › specs/send/send-btc.spec.ts:32:5 › send btc › btc send form › that recipient input is trimmed correctly
6 passed (4.7m)
|
Loading