fix: Ledger - cancel properly and don't allow user to close non cancellable sections #5597
Annotations
8 errors, 2 warnings, and 1 notice
Run Playwright tests:
tests/specs/settings/settings.spec.ts#L8
1) [chromium] › specs/settings/settings.spec.ts:32:3 › Settings menu › that menu item can lock and unlock the extension
Test timeout of 30000ms exceeded while running "beforeEach" hook.
6 |
7 | test.describe('Settings menu', () => {
> 8 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage }) => {
| ^
9 | await globalPage.setupAndUseApiCalls(extensionId);
10 | await onboardingPage.signInWithTestAccount(extensionId);
11 | });
at /home/runner/work/extension/extension/tests/specs/settings/settings.spec.ts:8:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L286
1) [chromium] › specs/settings/settings.spec.ts:32:3 › Settings menu › that menu item can lock and unlock the extension
Error: page.evaluate: Target page, context or browser has been closed
at page-object-models/onboarding.page.ts:286
284 | const isUnlockPage = async () => await this.page.getByText('Enter your password').isVisible();
285 | while (!(await isUnlockPage())) {
> 286 | await this.page.evaluate(
| ^
287 | async walletState => await chrome.storage.local.set({ 'persist:root': walletState }),
288 | testSoftwareAccountDefaultWalletState
289 | );
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:286:23)
at /home/runner/work/extension/extension/tests/specs/settings/settings.spec.ts:10:5
|
Run Playwright tests:
tests/specs/swap/swap.spec.ts#L6
2) [chromium] › specs/swap/swap.spec.ts:13:3 › Swaps › that it defaults to swapping STX ──────────
Test timeout of 30000ms exceeded while running "beforeEach" hook.
4 |
5 | test.describe('Swaps', () => {
> 6 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, swapPage }) => {
| ^
7 | await globalPage.setupAndUseApiCalls(extensionId);
8 | await onboardingPage.signInWithTestAccount(extensionId);
9 | await homePage.swapButton.click();
at /home/runner/work/extension/extension/tests/specs/swap/swap.spec.ts:6:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
2) [chromium] › specs/swap/swap.spec.ts:13:3 › Swaps › that it defaults to swapping STX ──────────
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/swap/swap.spec.ts:8:5
|
Run Playwright tests:
tests/specs/swap/swap.spec.ts#L6
3) [chromium] › specs/swap/swap.spec.ts:17:3 › Swaps › that it shows swap review details correctly
Test timeout of 30000ms exceeded while running "beforeEach" hook.
4 |
5 | test.describe('Swaps', () => {
> 6 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, swapPage }) => {
| ^
7 | await globalPage.setupAndUseApiCalls(extensionId);
8 | await onboardingPage.signInWithTestAccount(extensionId);
9 | await homePage.swapButton.click();
at /home/runner/work/extension/extension/tests/specs/swap/swap.spec.ts:6:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L296
3) [chromium] › specs/swap/swap.spec.ts:17:3 › Swaps › that it shows swap review details correctly
Error: locator.waitFor: Target page, context or browser has been closed
Call log:
- waiting for locator('text="Account 1"') to be visible
at page-object-models/onboarding.page.ts:296
294 | await this.page.getByRole('button', { name: 'Continue' }).click();
295 | await this.page.waitForURL('**' + RouteUrls.Home);
> 296 | await this.page.locator('text="Account 1"').waitFor();
| ^
297 | }
298 |
299 | /**
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:296:49)
at /home/runner/work/extension/extension/tests/specs/swap/swap.spec.ts:8:5
|
Run Playwright tests:
tests/specs/transactions/transactions.spec.ts#L12
4) [chromium] › specs/transactions/transactions.spec.ts:24:5 › Transaction signing › Contract calls › that it validates against insufficient funds when performing a contract call
Test timeout of 30000ms exceeded while running "beforeEach" hook.
10 | let testAppPage: TestAppPage;
11 |
> 12 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, context }) => {
| ^
13 | await globalPage.setupAndUseApiCalls(extensionId);
14 | await onboardingPage.signInWithTestAccount(extensionId);
15 |
at /home/runner/work/extension/extension/tests/specs/transactions/transactions.spec.ts:12:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L296
4) [chromium] › specs/transactions/transactions.spec.ts:24:5 › Transaction signing › Contract calls › that it validates against insufficient funds when performing a contract call
Error: locator.waitFor: Target page, context or browser has been closed
Call log:
- waiting for locator('text="Account 1"') to be visible
at page-object-models/onboarding.page.ts:296
294 | await this.page.getByRole('button', { name: 'Continue' }).click();
295 | await this.page.waitForURL('**' + RouteUrls.Home);
> 296 | await this.page.locator('text="Account 1"').waitFor();
| ^
297 | }
298 |
299 | /**
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:296:49)
at /home/runner/work/extension/extension/tests/specs/transactions/transactions.spec.ts:14:5
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: nick-fields/retry@v2, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "all-blob-reports".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Run Playwright tests
4 flaky
[chromium] › specs/settings/settings.spec.ts:32:3 › Settings menu › that menu item can lock and unlock the extension
[chromium] › specs/swap/swap.spec.ts:13:3 › Swaps › that it defaults to swapping STX ───────────
[chromium] › specs/swap/swap.spec.ts:17:3 › Swaps › that it shows swap review details correctly
[chromium] › specs/transactions/transactions.spec.ts:24:5 › Transaction signing › Contract calls › that it validates against insufficient funds when performing a contract call
1 skipped
5 passed (4.5m)
|
Loading