refactor: item interactive #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
approved these changes
Feb 29, 2024
fbwoolf
approved these changes
Feb 29, 2024
|
Re-ran the jobs to try get this merged. I can't see how this would cause shard 3 + 8 to fail so we can revisit improving tests soon. |
|
Also confused. It's a pretty minor UI change. Fara's avatar and my other PR run fine. |
kyranjamie
force-pushed
the
refactor/item-interactive
branch
from
000ba9f to
275186b
Compare
kyranjamie
force-pushed
the
refactor/item-interactive
branch
from
275186b to
52c6689
Compare
|
Turns out it was because of some strange behaviour with the psuedo element where in practice it was clickable, but in the test it wasn't able to click it. Pointer events fixes. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix PR that removes margins from item interactive and applies hover state with pseudo element. This should help @pete-watters