fix: check utxos fallback error, closes #5250 #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
changed the title
alter-eggo
force-pushed
the
fix/bestinslot-fallback
branch
from
a89b2f5 to
7bdb611
Compare
pete-watters
approved these changes
Apr 18, 2024
Merged
kyranjamie
reviewed
Apr 18, 2024
tests/specs/send/send-btc.spec.ts
Outdated
| @@ -8,6 +8,8 @@ import { BtcFeeType } from '@shared/models/fees/bitcoin-fees.model'; | |||
|
|
|||
| import { test } from '../../fixtures/fixtures'; | |||
|
|
|||
| test.describe.configure({ mode: 'serial' }); | |||
There was a problem hiding this comment.
Can we remove? It's kinda brittle, each test should run in isolatoin
fbwoolf
approved these changes
Apr 18, 2024
alter-eggo
force-pushed
the
fix/bestinslot-fallback
branch
from
7bdb611 to
1bac374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes bug with bestinslot fallback logic in check utxos flow