fix: remove ledger add more keys route, ref #4786

[pete-watters]

Try out Leather build 74ed8e7 — Extension build, Test report, Storybook, Chromatic

This PR removes ledger AddMoreKeysLayout and the route 'add-more-keys' found during investigation of #4786 which seems like it has been fixed.

See comment here

Summary by CodeRabbit

• Refactor
  • Removed the option to add more keys from the Ledger request keys feature.

[coderabbitai]

Walkthrough

The recent modifications streamline the Ledger request keys feature by eliminating the AddMoreKeysLayout component, impacting both the route configuration and the route enumeration. This change simplifies the overall routing structure by removing an unused path, thereby enhancing maintainability.

Changes

File Path	Change Summary
.../ledger-request-keys-route-generator.tsx	Removed AddMoreKeysLayout import and its corresponding route.
src/shared/route-urls.ts	Deleted LedgerAddMoreKeys from RouteUrls enum.

🐰✨📜
In the land of code, where the routes do weave,
A change was made, one less path to perceive.
No more keys to add, on this peculiar day,
Simplifying the map, the rabbit's joyful ballet.
Hop, skip, a tweak so neat,
CodeRabbit celebrates, with a carrot treat! 🥕
🐾🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 540c349 and 74ed8e7.

Files selected for processing (2)

• src/app/features/ledger/generic-flows/request-keys/ledger-request-keys-route-generator.tsx (2 hunks)
• src/shared/route-urls.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• src/shared/route-urls.ts

Additional comments not posted (1)

src/app/features/ledger/generic-flows/request-keys/ledger-request-keys-route-generator.tsx (1)

Line range hint 1-20: Verify removal of AddMoreKeysLayout and associated route.

Verification successful

---

The shell script results indicate that there are no remaining references to AddMoreKeysLayout or RouteUrls.LedgerAddMoreKeys in the TypeScript files of the codebase. This suggests that the removal of the specified route and its associated component has been handled correctly, with no orphaned references left behind.

Final Response

The verification process confirms that the AddMoreKeysLayout component and the RouteUrls.LedgerAddMoreKeys route have been completely removed from the codebase without leaving any orphaned references or imports. This aligns with the intended changes described in the PR.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that `AddMoreKeysLayout` and its route are completely removed and no orphaned references exist.

# Check for any remaining references to `AddMoreKeysLayout` in the TypeScript files.
rg --type ts 'AddMoreKeysLayout'

# Check for any remaining usage of `RouteUrls.LedgerAddMoreKeys` in the TypeScript files.
rg --type ts 'RouteUrls.LedgerAddMoreKeys'

Length of output: 75