feat: sbtc integration #5991
feat: sbtc integration #5991
Conversation
kyranjamie
force-pushed
the
feat/display-sbtc
branch
11 times, most recently
from
ac141e6 to
190d197
Compare
|
Let's link to an issue on the board? |
I'll look for an issue. I just stepped in to take this over, so I'm not sure what issue it relates to specifically. I think we are just trying to get a POC working for the sBTC deposit tx, and then we can apply that to swaps UI. |
|
Just an update here, working branched off on adding all the stuff needed to the swaps UI while we wait on the sbtc pkg update. I think tracking all the changes needed to update the stacks.js pkgs with copying the code over will be quite a chunk of work, so stalling for the lib update from Hiro. I will circle back to tracking the updates if that lib doesn't move fwd in the next few days. |
|
sbtc pkg was updated, so I'll update here and hopefully remove copied code 🤞 https://www.npmjs.com/package/sbtc |
fbwoolf
force-pushed
the
feat/display-sbtc
branch
from
b9406bf to
8530e51
Compare
|
Made the update, but testnet client is still broken. Got to this point thou...
|
|
Swaps UI draft here: #5997 |
|
The sbtc pkg was updated again with new documentation, I think I got the start of the deposit tx working. I believe we just need to add the inputs to it... 
|
fbwoolf
force-pushed
the
feat/display-sbtc
branch
2 times, most recently
from
a72120a to
dff2e4f
Compare
|
Ok, got the inputs and signed/finalized tx working... have not tried broadcasting yet. 
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/app/pages/swap/components/swap-assets-pair/swap-asset-item.layout.tsx
Fixed
Show resolved
Hide resolved
|
As an update, currently stuck here and waiting for feedback... https://github.com/hirosystems/stacks.js/pull/1554/files#r1870157852 |
fbwoolf
changed the title
fbwoolf
force-pushed
the
feat/display-sbtc
branch
3 times, most recently
from
69a66fe to
96fcbfe
Compare
|
@kyranjamie we seem to be using both |
|
I'm wondering if we should hide this banner somehow once the user has enrolled (or if they're not interested). We could try to detect on-chain enrollment, though it may be easiest to add a simply dismiss option that saves its hidden state client-side in cache? 
|
|
The BTC transaction to bridge appeared in activity for me, but I'm not seeing a separate bridging activity item on the Stacks side: 
|
| useEffect(() => { | ||
| // Clear quote amount if quote asset is reset | ||
| if (isUndefined(values.swapAssetQuote)) { | ||
| void setFieldValue('swapAmountQuote', ''); | ||
| } | ||
| }, [setFieldValue, values]); |
There was a problem hiding this comment.
I wonder if there are other ways we can do this. Seems kinda side effecty to have this component setting/updating state like this
src/app/pages/swap/components/swap-assets-pair/swap-assets-pair.tsx
Outdated
Show resolved
Hide resolved
src/app/pages/swap/components/swap-assets-pair/swap-assets-pair.tsx
Outdated
Show resolved
Hide resolved
| const { balance } = useBtcCryptoAssetBalanceNativeSegwit(currentBitcoinAddress); | ||
| const bitcoinMarketData = useCryptoCurrencyMarketDataMeanAverage('BTC'); | ||
|
|
||
| return useCallback((): SwapAsset => { |
There was a problem hiding this comment.
Could be a useMemo?
fbwoolf
force-pushed
the
feat/display-sbtc
branch
3 times, most recently
from
85c4e68 to
7229768
Compare
fbwoolf
force-pushed
the
feat/display-sbtc
branch
2 times, most recently
from
bbabe49 to
c4c0b7a
Compare
camerow
force-pushed
the
feat/display-sbtc
branch
from
c4c0b7a to
d60d444
Compare
|
Let's add "BTC" as a suffix here for max signer fee? 
|
alter-eggo
force-pushed
the
feat/display-sbtc
branch
from
12d6e50 to
e618ccf
Compare
This PR ensures sBTC displays correctly, with market data.
There are several design variants I'm not entirely sure which we should go for. No icon for now because apparently there's a new one on the way.
I'm a bit uncertain how we should handle sBTC specific behaviour. Either we can treat is separately from other SIP-10s or, manipulate the data/events we pass to the SIP-10 components such that it displays/behaves as we expect. Trying to avoid lots of
if (symbol === 'sBTC')-like code.