Make memory monitor configurable and disable it by default #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
force-pushed
the
feature/memory-monitor-disable
branch
2 times, most recently
from
626c175 to
f0186d5
Compare
Makes sense, will change it. |
The memory monitor has been observed to cause system performance degradation in some cases. Since it is still in the early stages of integration into production, it is important to provide a safe and convenient way to disable it if issues arise. To address this, this commit introduces a new global config option, `memory-monitor.enabled`, which allows dynamically enabling or disabling the memory monitor. When not set, the memory monitor container will be paused, effectively stopping its operation without requiring manual intervention. Technically, the memory monitor container always starts with the system, regardless of the config setting. If `memory-monitor.enabled` is set to `false`, the container will be paused as soon as the global config is parsed. This ensures that the option is applied early after device startup while maintaining a consistent container lifecycle. To implement this, the commit adds `MemoryMonitorEnabled` to the global settings, introduces logic to pause or resume the memory monitor container via containerd, and updates the global config handling to apply the new setting dynamically. Signed-off-by: Nikolay Martyanov <[email protected]>
OhmSpectator
force-pushed
the
feature/memory-monitor-disable
branch
from
f0186d5 to
12861ce
Compare
Fixed |
|
I would also like to bring the exact change in 13.4... To make it less risky during the upgrade. |
eriknordmark
approved these changes
Feb 11, 2025
This commit updates the documentation to include the `memory-monitor.enabled` global configuration option. It explains how the option can be used to start the memory monitor if needed and notes its potential impact on system performance. Signed-off-by: Nikolay Martyanov <[email protected]>
The memory monitor is a new component with limited real-world testing. To ensure system stability, it is now disabled by default. Users can enable it manually if needed. This commit updates the default value of `memory-monitor.enabled` to `false` in the global config and documentation, reflecting the change in behavior. Signed-off-by: Nikolay Martyanov <[email protected]>
OhmSpectator
force-pushed
the
feature/memory-monitor-disable
branch
from
12861ce to
8f81e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to enable or disable the memory monitor dynamically through the global configuration option
memory-monitor.enabled. Since the memory monitor is a new component with limited real-world testing, it is disabled by default to ensure system stability. Users can enable it manually if needed.The changes include:
memory-monitor.enabledto the global config and updating handling logic to pause or resume the memory monitor container accordingly.memory-monitor.enabledto false so the memory monitor starts in a paused state unless explicitly enabled.This ensures that the system remains stable while allowing users to experiment with the memory monitor when needed.