-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maximum Inscribed Circle #311
Add Maximum Inscribed Circle #311
Conversation
Did you see #310 ? |
Wow, I did not see that. Beat me by a few days... |
Also see this JTS blog post for more background. My guess is that the iterative approach in #310 will be faster than the densified Voronoi approach. Would be interesting if you can compare them. Also note that I plan to add a "viewport constraint" as well, to be able to find the visual centre of. a polygon which is only partially visible in a rectangular viewport. And finally, others have experimented with this for label placement, and have actually decided that in itself MIC is not ideal for labelling. See some discussion in the Mapnik project for instance [1][2]. [1] mapnik/mapnik#3780 |
This enhancement to weight using centroid might also be worthwhile for labelling purposes: Of course this is no longer the MIC then. |
@dr-jts Thank you very much for the links. That info is very insightful. I'll see if I can write a comparison once the iterative method is merged in. I will go ahead and close this PR. |
A Voronoi-based maximum inscribed circle algorithm based on the JavaScript library max-inscribed-circle.
OSGeo ticket https://trac.osgeo.org/geos/ticket/1028.