Code

Add Maximum Inscribed Circle#311

Code

Closed

PieceMaker wants to merge 57 commits intolibgeos:masterlibgeos/geos:masterfrom PieceMaker:jadams-add-max-inscribed-circlePieceMaker/geos:jadams-add-max-inscribed-circleCopy head branch name to clipboard

+920

Commits

Commits on Apr 2, 2020

• Start adding structure based on MinimumBoundingCircle.

  PieceMaker

  committed
  73a9e4d

• Add separate example file that currently outputs ring coords.

  PieceMaker

  committed
  7d6cf32

• Change some types and adjust some formatting.

  PieceMaker

  committed
  80153ab

• Added missing namespaces.

  PieceMaker

  committed
  e000e74

• Simplify polygons as they don't need to be so big.

  PieceMaker

  committed
  9aedb27

• Add max inscribed circle to make file so we can start compiling.

  PieceMaker

  committed
  1525c8a

• Somehow commit the output.

  PieceMaker

  committed
  ae5cc9a

• Reorganize so compute method tries to replicate one from MBC.

  PieceMaker

  committed
  7755bcc

Commits on Apr 5, 2020

• Rework to intake a geometry instead of poly. Also change segment type.

  PieceMaker

  committed
  0dd16f1

• Add functionality to pull polygon of largest area from multipoly.

  PieceMaker

  committed
  c68406c

• Add function for printing coordinates.

  PieceMaker

  committed
  c9037f2

Commits on Apr 6, 2020

• Added checking helpers, cout statements, and fixed incorrect types.

  PieceMaker

  committed
  abe4caf

• Was double-pushing from-points.

  PieceMaker

  committed
  1e0f3ae

Commits on Apr 7, 2020

• Change where sites are instantiated.

  PieceMaker

  committed
  df5cd86

• Change for loop variable type back to unsigned int.

  PieceMaker

  committed
  84be76f

• Was accidentally n-secting start point with (0,0). This removed duplicates.

  PieceMaker

  committed
  d28c50d

• Switch to if-else chain instead of separate if statements.

  PieceMaker

  committed
  b63af09

• Add temporary method that will return generated voronoi vertices.

  PieceMaker

  committed
  892def6

• Returns were short-circuiting the rest of the calculation.

  PieceMaker

  committed
  1ab74a0

• Get the coordinate sequence factory from the geometry factory.

  PieceMaker

  committed
  2276e21

• Pass entire geometry to unique extractor instead of looping.

  PieceMaker

  committed
  316cccb

Commits on Apr 8, 2020

• Return array of points since points are used for intersection check.

  PieceMaker

  committed
  54bdc25

• Rework example to expect array of points instead of coordinates.

  PieceMaker

  committed
  60b2cdb

• Remove some extra cout statements.

  PieceMaker

  committed
  9a87fbd

• Filter vertices so only those that intersect input geom are returned.

  PieceMaker

  committed
  86e2680

• Make polygon a member instead of passing it to functions.

  PieceMaker

  committed
  98309ad

• Add final piece that determines center and radius of MIC estimate.

  PieceMaker

  committed
  35cf00a

Commits on Apr 9, 2020

• Remove sites as member since voronoi takes ownership and modifies it.

  PieceMaker

  committed
  fa8ffc8

• Remove namespace since I have using.

  PieceMaker

  committed
  294acdb

• Remove unused include.

  PieceMaker

  committed
  d570204

• Forgot to remove call to computeSites() from compute();

  PieceMaker

  committed
  49cefa3

• Finish implementing getCircle and shortcircuit compute.

  PieceMaker

  committed
  b00a0ac

• A bounding box was never needed.

  PieceMaker

  committed
  594b319

• Implement getRadius() and simplify example file.

  PieceMaker

  committed
  97475d2

• Use explicit type in for-loop instead of auto.

  PieceMaker

  committed
  9934d5e

• Accidentally redefined poly in the case of multipolygon.

  PieceMaker

  committed
  ae4e153

• Fix compiler warnings.

  PieceMaker

  committed
  96c9a62

Commits on Apr 10, 2020

• Add unit test structure with two tests. More to come.

  PieceMaker

  committed
  78c13b7

• Add more tests and fix bug in checking centers.

  PieceMaker

  committed
  a7477c6

• Add tests for increasing number of segments.

  PieceMaker

  committed
  9ed569a

• Make sure the returned center intersects the geometry.

  PieceMaker

  committed
  ef00d6c

• Formatting.

  PieceMaker

  committed
  3d1ce88

• Switch spelling from "center" to "centre".

  PieceMaker

  committed
  42c844b

• Fix line endings as they're causing a test breakage.

  PieceMaker

  committed
  5718bf6

• Remove some unnecessary cout statements used for development.

  PieceMaker

  committed
  f1b3f4d

Commits on Apr 12, 2020

• Add maximum inscribed to capi and add structure for tests with one test.

  PieceMaker

  committed
  6cfc705

• Fix segfault bug with empty polygons found in testing.

  PieceMaker

  committed
  5c62ee8

• Add test for degenerate polygon.

  PieceMaker

  committed
  7a854bc

• Also add a line string test.

  PieceMaker

  committed
  3a33cab

• Add more tests of capi maximum inscribed circle.

  PieceMaker

  committed
  6369e8e

• Remove temporary helper functions.

  PieceMaker

  committed
  179cc4d

Commits on Apr 13, 2020

• Replace geometry type if-chain with switch statement.

  PieceMaker

  committed
  877a2b0

• Fixed a couple of test comments.

  PieceMaker

  committed
  bfae261

• Pull factory from inputed geometry.

  PieceMaker

  committed
  1061ff7

• Remove TODOs.

  PieceMaker

  committed
  ec3a4dc

• Update docs.

  PieceMaker

  committed
  05ecc6d

• Remove my personal example.

  PieceMaker

  committed
  3732abe