Simplify QEMU write path #2923
Open
Simplify QEMU write path #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nirs |
nirs
reviewed
Nov 19, 2024
| if err != nil { | ||
| return 0, err | ||
| } | ||
| start += nw | ||
| b = b[n:] |
There was a problem hiding this comment.
The new code saves one line, but it makes the intent of the code less clear, and in case of errors it is harder to report how many bytes we copied. I would keep the code as is but lets see what others think.
There was a problem hiding this comment.
This pattern is pretty common in the standard library: https://cs.opensource.google/search?q=for%5C%20len%5C(.*%5C)%5C%20(!%3D%7C%3E)%5C%200&sq=&ss=go%2Fgo
Signed-off-by: Tamir Duberstein <[email protected]>
tamird
force-pushed
the
cleaner-writing
branch
from
1b6ac94
to
6916da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tamir Duberstein [email protected]