Reduced the number of validators in the Local Kube tests to 1. #3154
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-ds
approved these changes
Jan 20, 2025
| @@ -97,7 +97,7 @@ impl SharedLocalKubernetesNetTestingConfig { | |||
| testing_prng_seed: Some(37), | |||
| num_other_initial_chains: 2, | |||
| initial_amount: Amount::from_tokens(2000), | |||
| num_initial_validators: 4, | |||
| num_initial_validators: 1, | |||
There was a problem hiding this comment.
We could even do 2, I think, and it would probably still mitigate the issue (if we want to keep kind testing more than 1 validator still, but maybe that's not needed)
There was a problem hiding this comment.
In terms of test coverage, 2 is not better than 1, so I would pick 1
christos-h
force-pushed
the
change-local-kubernetes-validator-num
branch
from
f776c02 to
7feffbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having 4 validators for the
kindtests is unnecessary. Storage service tests will catch any consensus related regressions.Proposal
Reduce the number of validators to 1.
Test Plan
CI will catch regressions.
Release Plan