Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the number of validators in the Local Kube tests to 1. #3154

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
-t ${{ env.DOCKER_IMAGE }}:${{ env.BRANCH_NAME }} \
-t ${{ env.DOCKER_IMAGE }}:${{ env.GIT_COMMIT_SHORT }} \
-t ${{ env.DOCKER_IMAGE }}:${{ env.GIT_COMMIT_LONG }}

docker run --rm linera ./linera --version
- name: Push Docker image to Google Artifact Registry
run: |
docker push ${{ env.DOCKER_IMAGE }}:${{ env.BRANCH_NAME }}
Expand Down
96 changes: 96 additions & 0 deletions .github/workflows/kubernetes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
name: Kubernetes

on:
push:
branches: [ main ]
pull_request:
branches:
- "**"
paths:
- '.github/workflows/kubernetes.yml'
- 'toolchains/**'
- 'configuration/**'
- 'docker/**'
- 'kubernetes/**'
- 'linera-service/**'
- 'linera-rpc/**'
workflow_dispatch:

# This allows a subsequently queued workflow run to interrupt previous runs on pull-requests
concurrency:
group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.run_id }}'
cancel-in-progress: true

env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
CARGO_NET_RETRY: 10
RUST_BACKTRACE: short
RUSTFLAGS: "-D warnings"
RUSTUP_MAX_RETRIES: 10
LINERA_TRY_RELEASE_BINARIES: "true"

permissions:
contents: read

jobs:
kind-deployment-e2e-tests:
runs-on: ubuntu-latest-16-cores
timeout-minutes: 90

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Build client binary
run: |
cargo build --release --locked --bin linera --bin linera-proxy --bin linera-server --features scylladb,rocksdb,kubernetes,metrics
strip target/release/linera
strip target/release/linera-proxy
strip target/release/linera-server
- name: Setup helmfile
uses: mamezou-tech/[email protected]
- name: Run e2e tests
uses: nick-fields/retry@v2
with:
# Port forwarding sometimes dies, which makes all requests timeout
# Which is why we need retries
max_attempts: 1
timeout_minutes: 20
command: |
kind get clusters | xargs -I {} kind delete cluster --name {}
RUST_LOG=linera=info cargo test --locked -p linera-service --features scylladb,kubernetes --test linera_net_tests -- kubernetes --nocapture
- name: Setup upterm session
uses: lhotari/action-upterm@v1
if: ${{ failure() }}
with:
wait-timeout-minutes: 120
- name: Port forward Prometheus
run: |
kubectl port-forward prometheus-linera-core-kube-prometheu-prometheus-0 9090 &
- name: Check Proxy metric
# Check one random proxy metric that we expect to be logged after running the e2e tests
run: |
curl -s 'http://127.0.0.1:9090/api/v1/query?query=linera_proxy_request_latency_bucket' | jq -r '.data.result[]' | grep -q .
- name: Check Server metric
# Check one random server metric that we expect to be logged after running the e2e tests
run: |
curl -s 'http://127.0.0.1:9090/api/v1/query?query=linera_server_request_latency_bucket' | jq -r '.data.result[]' | grep -q .
- name: Check Scylla metric
# Check one random server metric that we expect to be logged after running the e2e tests
run: |
curl -s 'http://127.0.0.1:9090/api/v1/query?query=scylla_database_total_reads' | jq -r '.data.result[]' | grep -q .
- name: Check Scylla Manager metric
# Check one random server metric that we expect to be logged after running the e2e tests
run: |
curl -s 'http://127.0.0.1:9090/api/v1/query?query=scylla_manager_agent_rclone_bytes_transferred_total' | jq -r '.data.result[]' | grep -q .
- name: Destroy the kind clusters
if: always()
shell: bash
run: >-
kind get clusters | xargs -I {} kind delete cluster --name {}
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ARG target=x86_64-unknown-linux-gnu
ARG binaries=
ARG copy=${binaries:+_copy}

FROM rust:1.74-slim-bookworm AS builder
FROM rust:1.81-slim-bookworm AS builder
ARG git_commit
ARG target

Expand Down
2 changes: 1 addition & 1 deletion linera-service/src/cli_wrappers/local_kubernetes_net.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ impl SharedLocalKubernetesNetTestingConfig {
testing_prng_seed: Some(37),
num_other_initial_chains: 2,
initial_amount: Amount::from_tokens(2000),
num_initial_validators: 4,
num_initial_validators: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even do 2, I think, and it would probably still mitigate the issue (if we want to keep kind testing more than 1 validator still, but maybe that's not needed)

Copy link
Contributor

@ma2bd ma2bd Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of test coverage, 2 is not better than 1, so I would pick 1

num_shards: 4,
binaries,
no_build: false,
Expand Down
Loading