Make generated block proposals cancel each other out #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@ndr-ds It's already a rotation |
|
Ah, I guess it is, but there's a bug. The bug made me think this wasn't actually supposed to rotate. I'll just fix the bug in this PR then. |
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
29ae5ec to
1822992
Compare
ndr-ds
commented
Feb 5, 2025
| @@ -959,7 +959,11 @@ where | |||
| fungible_application_id: Option<ApplicationId>, | |||
| ) -> Vec<RpcMessage> { | |||
| let mut proposals = Vec::new(); | |||
| let mut next_recipient = self.wallet.last_chain().unwrap().chain_id; | |||
There was a problem hiding this comment.
If you run it with 100 chains, then after that you run with 10 chains, your wallet will actually still have 100 chains, but you're only gonna use the first 10. So in this case, the last chain in the wallet won't actually match the last chain in the key_pairs. But for this to properly rotate and cancel each other out, it needs to always match the last chain in key_pairs.
afck
approved these changes
Feb 5, 2025
| @@ -959,7 +959,11 @@ where | |||
| fungible_application_id: Option<ApplicationId>, | |||
| ) -> Vec<RpcMessage> { | |||
| let mut proposals = Vec::new(); | |||
| let mut next_recipient = self.wallet.last_chain().unwrap().chain_id; | |||
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
8bfe558 to
b48ea1f
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
1822992 to
3467d73
Compare
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
b48ea1f to
33bf983
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
3467d73 to
2fba85e
Compare
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
33bf983 to
a480e16
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
2fba85e to
83f3775
Compare
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
a480e16 to
eed7006
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
83f3775 to
646f774
Compare
This comment was marked as spam.
This comment was marked as spam.
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
eed7006 to
98d8d58
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
646f774 to
66caa6a
Compare
ndr-ds
force-pushed
the
02-03-parallelize_staging_block_execution
branch
from
98d8d58 to
add6a9c
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
2 times, most recently
from
7936bf0 to
8d32a72
Compare
ndr-ds
changed the base branch from
02-03-parallelize_staging_block_execution
to
02-03-parallelize_supply_fungible_tokens
ndr-ds
force-pushed
the
02-03-parallelize_supply_fungible_tokens
branch
from
90c2c62 to
8bdcfb6
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
8d32a72 to
9d2a160
Compare
ndr-ds
changed the base branch from
02-03-parallelize_supply_fungible_tokens
to
graphite-base/3249
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
9d2a160 to
6a3fb45
Compare
ndr-ds
deleted the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
This was referenced Feb 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The block proposals are supposed to rotate and cancel each other out, but there's currently a bug in how we do it.
Proposal
Fix the bug
Test Plan
CI + ran locally
Release Plan