make_benchmark_block_proposals now returns BlockProposals #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
83f3775 to
646f774
Compare
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
4909c0e to
b0e57b7
Compare
afck
approved these changes
Feb 6, 2025
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
646f774 to
66caa6a
Compare
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
b0e57b7 to
89a96c3
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
66caa6a to
7936bf0
Compare
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
89a96c3 to
d10477e
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
7936bf0 to
8d32a72
Compare
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
d10477e to
e54f165
Compare
ndr-ds
force-pushed
the
02-04-make_generated_block_proposals_cancel_each_other_out
branch
from
8d32a72 to
9d2a160
Compare
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
e54f165 to
e0c17fe
Compare
ndr-ds
changed the base branch from
02-04-make_generated_block_proposals_cancel_each_other_out
to
graphite-base/3264
ndr-ds
force-pushed
the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
from
e0c17fe to
c66f7fa
Compare
ndr-ds
deleted the
02-05-make_benchmark_block_proposals_now_returns_blockproposals
branch
This was referenced Feb 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This
RpcMessagetype is needed only when callingmass_broadcast, and it makes the code a bit more awkward because you have to check if it's a block proposal, when it'll always beProposal
Return the actual
BlockProposals instead, and only convert them when needed.Test Plan
CI + ran locally
Release Plan