Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NovaCustom V540TU board #1846

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

mkopec
Copy link
Contributor

@mkopec mkopec commented Nov 14, 2024

Add NovaCustom V540TU board (14" V54 Series, Meteor Lake, Integrated graphics)

@macpijan
Copy link
Contributor

@mkopec Do we plan to add here the rest of the variants as well?

@mkopec
Copy link
Contributor Author

mkopec commented Nov 14, 2024

@macpijan sure, after one starts working I'll do the rest too

@tlaurion
Copy link
Collaborator

@macpijan @mkopec similar commit needed for #1835

@tlaurion
Copy link
Collaborator

@mkopec this comment might be helpful #1835 (comment)

@tlaurion
Copy link
Collaborator

@mkopec

mkc: seems like kernel 6.7+ is bare minimal for meteor lake, with efifb fixes having landed under 6.8+?

Also, if you pass serial to kernel boot options under coreboot config, you should get logs of the kernel?

At https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$bVtsV3M_sz0MroFsDkXRGQ3ow7OhumKqtAllchkAyKs?via=matrix.org&via=nitro.chat&via=envs.net

@mkopec
Copy link
Contributor Author

mkopec commented Nov 22, 2024

mkc: seems like kernel 6.7+ is bare minimal for meteor lake, with efifb fixes having landed under 6.8+?

possible, in Ubuntu and Fedora we found it best to have Linux 6.8 or newer (6.9 also has a fix for s0ix but that's irrelevant for Heads)

@tlaurion do you think you can help with updating the kernel?

@tlaurion
Copy link
Collaborator

tlaurion commented Nov 22, 2024

I read that 6.12 will be next Lts but that is only speculation.

edit: We choose 6.11.9 for all novacustom boards?
I can give it a shot, yes, and leave traces in commit, taking this PR state as a base.

@mkopec did serial console passed per coreboot config to kernel gave you more info?
With debug as well. See qemu coreboot config, non-prod.

mkopec and others added 13 commits November 22, 2024 11:56
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
…ent upstream

Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
…place -> +linux.save_in_olddefconfig_format_in_place, to be used for kernel version bump newly added defconfig under oldconfig (->olddefconfig)

Signed-off-by: Thierry Laurion <[email protected]>
…ig changes without modification './docker_repro.sh make BOARD=novacustom-v540tu linux.save_in_olddefconfig_format_in_place'

Signed-off-by: Thierry Laurion <[email protected]>
…f things changed, see notes in this commit. Saved in olddefconfig './docker_repro.sh make BOARD=novacustom-v540tu linux.save_in_olddefconfig_format_in_place'

compare with : git difftool 510bc6e
Signed-off-by: Thierry Laurion <[email protected]>
…mode to ttyS0 (change accordingly)

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion
Copy link
Collaborator

tlaurion commented Nov 22, 2024

@mkopec there is a lot to tune under 6.11.9 kernel config which writes over shared linux config with other novacustom (config/linux-nitrokey-x.config, should probably renamed and all board configs point to new name as well).

See branch https://github.com/tlaurion/heads/tree/dasharo-add_novacustom_v540tu and feel free to steal adapt/change whatever. If you have questions, poke me where/if needed.

Note: compare config changes in commit 510bc6e to see all the new olddefconfig stuff applied silently when using defconfig. Ie, what happened with TRUST_CPU and so many other stuff to care about once you have something that boots.

See also that I changed your coreboot config to pass linux kernel options to be in debug, with probably wrong serial ttyS0, adapt accordingly and keep me posted. Small iterations in board porting has known good track history.

If you decided to tackle #1835 instead, I could help (if you guide me into how you get serial console output [even though this work wasn't planned nor in my plate up to now]).

@tlaurion
Copy link
Collaborator

tlaurion commented Nov 22, 2024

Edit:yep. Cannot bump Sandy to 6.11.9: as can be seen, all those do not have enough free spi space without another phase of #590 (not planned.)

@mkopec
Copy link
Contributor Author

mkopec commented Nov 27, 2024

Thanks for the patches @tlaurion , I'm testing them now, i'm not getting a serial console yet, I suspect the LPSS UART driver is missing, will try to fix

- enable X2APIC to allow Linux to finish booting
- enable serial console on LPSS UART

Signed-off-by: Michał Kopeć <[email protected]>
@tlaurion
Copy link
Collaborator

@mkopec #1865 merged, please rebase

@tlaurion
Copy link
Collaborator

tlaurion commented Nov 28, 2024

Thanks for the patches @tlaurion , I'm testing them now, i'm not getting a serial console yet, I suspect the LPSS UART driver is missing, will try to fix

@mkopec This needs updates, since reported off-channel to be all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants