-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch Dialect] Emit torch.aten.mul.float_int
, add folder and conversion to Arith.
#3750
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Similar comments as on the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions. Ping me when you make those and I'll approve the PR.
Co-authored-by: zjgarvey <[email protected]>
…shape calculation of `upsample_nearest2d`) (#3764) As per title. See also [PR](#3750) for `torch.aten.mul.float_int`. --------- Co-authored-by: zjgarvey <[email protected]>
…shape calculation of `upsample_nearest2d`) (#3764) As per title. See also [PR](#3750) for `torch.aten.mul.float_int`. --------- Co-authored-by: zjgarvey <[email protected]>
It does look like this needs to resolve some minor conflicts. Would you mind syncing with main so we can merge? |
Folder is required to simplify the shape calculation of
torch.aten.__interpolate.size_list_scale_list
:torch-mlir/lib/Dialect/Torch/Transforms/AbstractInterpLibrary.cpp
Lines 6900 to 6907 in 5eab669
(I've re-run
build_tools/update_abstract_interp_lib.sh
)