Review page: Display counts of different sequences statuses and allow filtering and improve loading CLS and restyle buttons #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
requested review from
corneliusroemer and
chaoran-chen
and removed request for
chaoran-chen and
corneliusroemer
This comment was marked as outdated.
This comment was marked as outdated.
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Show resolved
Hide resolved
theosanderson
force-pushed
the
reviewcounts
branch
from
2fa1253 to
1e7f6e9
Compare
corneliusroemer
previously requested changes
Mar 21, 2024
There was a problem hiding this comment.
Tooltip z score is not right, or the other way round, the top bar is too far in front
Turned into issue because not blocking: #1447
theosanderson
force-pushed
the
reviewcounts
branch
from
1e7f6e9 to
b1639c2
Compare
|
It isn't obvious to me that the tooltip z-index is "wrong" per se. It does look ugly here because the fixed header doesn't have 100% width. Otherwise I think it would be fine. Generally the design would be better if the fixed header had 100% width (the shadow that cuts off looks weird). But this is low priority for now. (It also isn't, as I understand it, easy to change the tooltip z-index). So not going to address that for now. |
theosanderson
dismissed
corneliusroemer’s stale review
This isn't a blocking issue
corneliusroemer
approved these changes
Mar 22, 2024
|
Will indeed merge, as I've taken Fabian's advice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1161, resolves #1034
preview URL: https://reviewcounts.loculus.org
Get the review page to display counts of sequences in different statuses and to allow toggling their visibility. Cache the old result and used it when grayed out when loading to avoid jumping to a totally white loading screen.
To get this to work we had to add an
initialStatusFilterto thegetSequencescall, which is applied initially, and applies to the counts. Then the second main filter is applied after the counts.Remaining issue: #1372