-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Run test actions only when relevant code changed for website, backend #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the website tests never touch the config files generated from kubernetes? (My instinct is that they indeed don't, but not totally sure)
Generally I'm not that worried about a bit of pointless CI especially when it's free (I find it quite useful as a control for things that do change the code), so am ambivalent here, but happy to go for it if people want it
Oh yeah I guess we can tell from these workflows that they don't |
I just think it's worth thinking about whether we'd have been as confident that we had flaky tests without pointless CI |
Fair point, though we can always trigger CI runs on main, we can reenable if we feel it becomes hard to tell flakiness apart |
Summary
Run backend and website test actions only when relevant code changed for backend, website respectively