Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Run test actions only when relevant code changed for website, backend #1695

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Apr 29, 2024

Summary

Run backend and website test actions only when relevant code changed for backend, website respectively

@corneliusroemer corneliusroemer changed the title less pointless ci chore(ci): Run test actions only when relevant code changed for website, backend Apr 29, 2024
@corneliusroemer corneliusroemer marked this pull request as ready for review April 29, 2024 12:32
@corneliusroemer corneliusroemer enabled auto-merge (squash) April 29, 2024 12:32
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the website tests never touch the config files generated from kubernetes? (My instinct is that they indeed don't, but not totally sure)

Generally I'm not that worried about a bit of pointless CI especially when it's free (I find it quite useful as a control for things that do change the code), so am ambivalent here, but happy to go for it if people want it

@theosanderson
Copy link
Member

theosanderson commented Apr 29, 2024

Do the website tests never touch the config files generated from kubernetes? (My instinct is that they indeed don't, but not totally sure)

Oh yeah I guess we can tell from these workflows that they don't

@theosanderson
Copy link
Member

I just think it's worth thinking about whether we'd have been as confident that we had flaky tests without pointless CI

@corneliusroemer
Copy link
Contributor Author

I just think it's worth thinking about whether we'd have been as confident that we had flaky tests without pointless CI

Fair point, though we can always trigger CI runs on main, we can reenable if we feel it becomes hard to tell flakiness apart

@corneliusroemer corneliusroemer merged commit 8a6535e into main Apr 29, 2024
13 checks passed
@corneliusroemer corneliusroemer deleted the less-pointless-ci branch April 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants