fix(k8s): check if backendExtraArgs is set, add test for default template #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late Recently merged PR expects backendExtraArgs to be present in values.yaml It isn't, so default way of generating helm templates crashes. Fixing and adding test to avoid this in future.
fengelniederhammer
approved these changes
May 22, 2024
|
No probs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently merged PR #1919 expects backendExtraArgs to be present in values.yaml
It isn't necessary, so default way of generating (and testing) helm templates (
helm template loculus kubernetes/loculus) crashes. Fixing and adding test to avoid this in future.