-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prepro): Allow nextclade metadata fields to be per_segment #2108
Conversation
This looks great! Thanks for tackling! I've opened an issue #2115 to improve how we show per-segment metadata in a more structure way. I've also formatted with ruff (it didn't seem to have been) and fixed mypy errors. These might have already pre-existed from the cchf merge (I haven't yet reviewed the prepro part of the code). See commit 8d4cb27 for my changes |
8d4cb27
to
4298b43
Compare
4298b43
to
34be11c
Compare
I just realized this PR makes the metadata spec very undry - I don't think this is necessary:
|
Simplification attempt: https://github.com/loculus-project/loculus/pull/2131/files |
preview URL: https://prepro-fix.loculus.org/
Fixes
In #2100 I mentioned that there is a bug in the prepro code when processing multi-segment nextclade alignments.
When all segments are merged:
When the L segment is uploaded individually:
Basically these alignment metrics need to be annotated as
per_segment
.Summary
per_segment
. In order to do this theper_segment
parameter must also be added as a field to thepreprocessing
arguments. For example:Screenshot