feat(deployment): allow "subdomain separator" to be customised #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
theosanderson
requested review from
anna-parker,
corneliusroemer and
chaoran-chen
and removed request for
anna-parker
corneliusroemer
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Thanks this is great!
How have you tested it? Checking the yaml that's rendered or also more?
Maybe we should a) make a preview deployment to see the previews still work and b) make a deployment that explicitly tests the . separator
Don't have any comments on the code. Feel free to merge, just curious about how you tested.
|
I tested it doesn't break the current set up by making a preview deployment (I'd done that already, to clarify, but hadn't included the URL). https://kc-rf.loculus.org/ Using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "logical" way our
authentication,backendetc. hosts should be specified is that we should have a main domain (or subdomain) e.g.pathoplexus.orgfor the website, and the backend should bebackend.pathoplexus.org. This can also theoretically work with subdomains, withbackend.pathoplexus.loculus.org. However we were running out of certificates with all our preview instances so we created a wildcard certificate for*.loculus.org. You cannot create a wildcard certificate with two wildcards (*.*.loculus.org) and so we have adopted a strategy where we instead use a pattern likeauthentication-pathoplexus.loculus.orgfor preview instances. However for the main pathoplexus instance we want to revert toauthentication.pathoplexus.orgso this PR adds a configurable valuesubdomainSeparatorthat can be set to-or.as we wish.