Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): customise IdpProfile page, to add same acceptance button used on main registration form #2294

Merged
merged 2 commits into from
Jul 23, 2024
Merged

feat(auth): customise IdpProfile page, to add same acceptance button used on main registration form #2294

merged 2 commits into from
Jul 23, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Jul 14, 2024 •
edited
Loading

resolves #1758

Previously registration using ORCID bypassed the acceptance of terms. Now it doesn't.

image

https://userprofile-customise.loculus.org

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Jul 14, 2024
@theosanderson theosanderson changed the title wip: customise IdpProfile page, ultimately to add acceptance of various things feat(auth): customise IdpProfile page, to add same acceptance button used on main registration form Jul 18, 2024
@theosanderson theosanderson added the review please PR waiting for final review label Jul 21, 2024
@corneliusroemer corneliusroemer force-pushed the userprofile-customise branch from f8cb45e to 2da6f4d Compare July 23, 2024 10:41
corneliusroemer
corneliusroemer approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Jul 23, 2024 •
edited
Loading

Small point: terms link goes to main.loculus.org/terms - just checking this is on purpose. This is probably a hard coded full URL in values.yaml and not relative to (preview-)subdomain?

@theosanderson
Copy link
Member Author

Yes, it's somewhat on purpose in that this is really just a feature for Pathoplexus for now

@theosanderson theosanderson merged commit c10dde4 into main Jul 23, 2024
9 checks passed
@theosanderson theosanderson deleted the userprofile-customise branch July 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

@anna-parker anna-parker Awaiting requested review from anna-parker

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd review please PR waiting for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ORCID registration has no "accept data use terms" checkbox
2 participants
@theosanderson @corneliusroemer