feat(ingest): Map more NCBI virus fields to Loculus fields #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
changed the title
anna-parker
requested review from
corneliusroemer,
chaoran-chen and
theosanderson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL: https://ingest-fields-update.loculus.org/
Summary
While compiling pathoplexus/pathoplexus#54 I realized there are more NCBI Virus fields we could map to Loculus fields, I have done this now. I also realized that ALL_FIELDS is unnecessary and removed it to avoid over complicating the defaults.yaml file and the ingest workflow.
Screenshot