Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): create e2e test for bulk download #2445

Merged
merged 18 commits into from
Aug 19, 2024
Merged

feat(e2e): create e2e test for bulk download #2445

merged 18 commits into from
Aug 19, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Aug 16, 2024 •
edited
Loading

Resolves #2444 by adding E2E tests that the downloads don't entirely fail for:

  • downloading metadata (default)
  • downloading raw nucleotide sequences

Currently downloading raw nucleotide sequences fails, which is correct behaviour from the test. I will not merge until I rebase on something such that that is passing.

@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Aug 16, 2024
@theosanderson theosanderson changed the title wip: create e2e test for download feat(e2e): create e2e test for download Aug 16, 2024
@theosanderson theosanderson changed the title feat(e2e): create e2e test for download feat(e2e): create e2e test for bulk download Aug 16, 2024
anna-parker
anna-parker approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! thanks for this!

@theosanderson theosanderson changed the base branch from main to lapis029silo0213 August 19, 2024 13:44
@theosanderson
Copy link
Member Author

Works when rebased :D

Base automatically changed from lapis029silo0213 to main August 19, 2024 13:56
@theosanderson theosanderson merged commit b98ff33 into main Aug 19, 2024
14 checks passed
@theosanderson theosanderson deleted the create-e2e-test-for-download branch August 19, 2024 14:14
theosanderson added a commit that referenced this pull request Aug 19, 2024
@theosanderson
Revert "feat(e2e): create e2e test for bulk download (#2445)"
e0294f6 
This reverts commit b98ff33.
@theosanderson theosanderson mentioned this pull request Aug 19, 2024
Merged
theosanderson added a commit that referenced this pull request Aug 20, 2024
@theosanderson
Revert "feat(e2e): create e2e test for bulk download (#2445)" (#2463)
be208eb 
This reverts commit b98ff33.
theosanderson added a commit that referenced this pull request Aug 20, 2024
@theosanderson
Revert "Revert "feat(e2e): create e2e test for bulk download (#2445)" (…
e61dfaf 
…#2463)"

This reverts commit be208eb.
@theosanderson theosanderson mentioned this pull request Aug 20, 2024
Merged
theosanderson added a commit that referenced this pull request Aug 20, 2024
@theosanderson
Reinstate e2e download test but disabled for webkit (#2465)
42efc5f 
* Revert "Revert "feat(e2e): create e2e test for bulk download (#2445)" (#2463)"

This reverts commit be208eb.

* skip download tests on webkit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker approved these changes

@chaoran-chen chaoran-chen chaoran-chen approved these changes

Assignees
No one assigned
Labels
format_me Triggers github_actions to format website code on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E test that makes a (bulk) download
4 participants
@theosanderson @chaoran-chen @anna-parker @fengelniederhammer