fix(deployment): Use a different key for sealed secrets data #2447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just spent a loooong time debugging a confusing issue on Pathoplexus. It manifested as the
database
sealed secret that couldn't be extracted as it appeared to be corrupt. It was very confusing because I could see the sealed secrets I had configured in values yaml and they hadn't changed. It turned out that what had happened was that we added a new keyhost
to the database secret in the default values.yaml recently. That default values yaml doesn't use sealed secrets at all, it defines them in a raw format. But because that value hadn't been added to pathoplexus's values.yaml in any form, and because pathoplexus values.yaml redefines the database secret as a sealed secret, what ended up happening was that the sealed secrets controller attempted to extract the host key, merged in from the default values yaml, even though that had never been sealed. This was so confusing to debug that I want to avoid it ever happening again, so now we will store sealed secrets underencryptedData
notdata
so that you cannot get merging of a sealed and unsealed secret.https://different-key-sealed-secr.loculus.org/