-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not align sequences and test on dummy pipeline. #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome to have at launch! Thanks so much. Gets to dodge at least one of our schema discussions. I think it would be great to have a bit less code duplication
theosanderson
approved these changes
Aug 22, 2024
… have less duplication
e3ed4a0
to
ffdfa6c
Compare
… problem - weird it hasn't come up before...
Co-authored-by: Theo Sanderson <[email protected]>
Co-authored-by: Theo Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2239
preview URL: https://add-no-alignment-prepro-o.loculus.org/
Summary
We keep saying it is easy to write a prepro pipeline without alignment/nextclade - this adds an option to our current nextclade pipeline to run without alignment/nextclade (always when no nextclade dataset is given). The nice thing about this is we still keep all the metadata field processing options.
Screenshot
PR Checklist