Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not align sequences and test on dummy pipeline. #2477

Merged
merged 20 commits into from
Aug 23, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Aug 21, 2024

resolves #2239

preview URL: https://add-no-alignment-prepro-o.loculus.org/

Summary

We keep saying it is easy to write a prepro pipeline without alignment/nextclade - this adds an option to our current nextclade pipeline to run without alignment/nextclade (always when no nextclade dataset is given). The nice thing about this is we still keep all the metadata field processing options.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • Tested locally - sadly alignment just shows as all Ns, but otherwise working as intended:
image

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Aug 21, 2024
@corneliusroemer corneliusroemer removed the preview Triggers a deployment to argocd label Aug 21, 2024
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Aug 21, 2024
@anna-parker anna-parker marked this pull request as ready for review August 21, 2024 20:43
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome to have at launch! Thanks so much. Gets to dodge at least one of our schema discussions. I think it would be great to have a bit less code duplication

@anna-parker anna-parker force-pushed the add_no_alignment_prepro_option branch from e3ed4a0 to ffdfa6c Compare August 23, 2024 10:51
@anna-parker anna-parker merged commit d72ec6d into main Aug 23, 2024
12 checks passed
@anna-parker anna-parker deleted the add_no_alignment_prepro_option branch August 23, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preprocessing config option to not require any dataset at all, simply output no aligned sequences
3 participants