Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force sync cronjob #2478

Closed
wants to merge 19 commits into from
Closed

force sync cronjob #2478

wants to merge 19 commits into from

Conversation

corneliusroemer
Copy link
Contributor

  • Update config, remove deployment, add revoke cronjob
  • Check if having the startingDeadlineSeconds half the length of the schedule frequency helps
  • Add approval step
  • Also add approve to regroup and revoke cronjob
  • Test out timeout
  • Add timeout only to approve
  • force replacement of cronjobs when sync is called
  • check if removing restartpolicy will let jobs be removed by argocd
  • Add back restart policy and do not throw error on timeout
  • lower approve_timeout for debugging
  • Just add approve_timeout to the python script
  • Remove double touch
  • Increase approve timeout to 5min for testing
  • force a sync by adding an echo statement
  • Remove reloader.stakater.com/auto: "true" just to check
  • Remove echo see if we can force sync
  • Empty commit
  • Try out 60min

resolves #

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Aug 21, 2024
@anna-parker
Copy link
Contributor

anna-parker commented Aug 22, 2024

State at start of test
image
Commited small change at 10.00:
Cronjobs are scheduled to run every 30min.
State after commit is synced:
image
It does look like a new job is created:
image
However, the job cannot start as the backend is not up yet:
image
Oh but ingest does try again!:
image
And now the logs are good - we just don't see this on argocd:
image
Probably it will only turn green when the cronjob completes which in this case is after a new one starts.
So that means this is fine!!!!

@anna-parker anna-parker removed the preview Triggers a deployment to argocd label Aug 22, 2024
@anna-parker
Copy link
Contributor

Merged in #2473

@anna-parker
Copy link
Contributor

Adding to this argocd creates a "new" pod in the same replicaset - that is also why it doesn't immediately look like the old cronjob has been stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants