Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): actually generate DOIs #2538

Merged
merged 8 commits into from
Aug 23, 2024
Merged

fix(backend): actually generate DOIs #2538

merged 8 commits into from
Aug 23, 2024

Conversation

chaoran-chen
Copy link
Member

This fixes a few minor issues in the DOI generation code and call it from the SeqSetCitationsDatabaseService.

Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me! Thanks a lot for this. I will push to later tonight and then merge.

@theosanderson
Copy link
Member

theosanderson commented Aug 23, 2024

I will merge this but there may be more PRs after we try it in production (due to my bit)

@theosanderson theosanderson merged commit 81c9a0d into main Aug 23, 2024
14 checks passed
@theosanderson theosanderson deleted the fix-doi-generation branch August 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants