WIP: Append two empty JSON objects to mark the end of the NDJSON stream #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
changed the title
anna-parker
added
preview
|
Instead of two empty objects, would two empty lines also work? I assume that the idea is that the client (our silo import script) will check for the empty objects / lines to determine whether a file is complete? |
|
Closing as we are going another way and this did not work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2724
preview URL: https://add-explicit-end-to-strea.loculus.org/
Summary
Currently we stream sequences using NDJSON for multiple endpoints, including get-released-data which sends clients all data. However, if the stream breaks off the client will not know that the server did not send all sequences. This lead to not all sequences being shown for west nile when we had high database load because the silo import script was calling get-released-data.
Screenshot
PR Checklist