Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add back versionComment field #3134

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,12 @@ open class ReleasedDataModel(
("versionStatus" to TextNode(versionStatus.name)),
("dataUseTerms" to TextNode(currentDataUseTerms.type.name)),
("dataUseTermsRestrictedUntil" to restrictedDataUseTermsUntil),
("versionComment" to TextNode(rawProcessedData.versionComment)),
).let {
) +
if (rawProcessedData.isRevocation) {
mapOf("versionComment" to TextNode(rawProcessedData.versionComment))
} else {
emptyMap()
}.let {
when (backendConfig.dataUseTermsUrls) {
null -> it
else -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ class GetReleasedDataEndpointTest(
"releasedDate" to TextNode(currentDate),
"submittedDate" to TextNode(currentDate),
"dataUseTermsRestrictedUntil" to NullNode.getInstance(),
"versionComment" to NullNode.getInstance(),
"booleanColumn" to BooleanNode.TRUE,
)

Expand Down
4 changes: 0 additions & 4 deletions kubernetes/loculus/templates/_common-metadata.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ fields:
type: string
notSearchable: true
hideOnSequenceDetailsPage: true
- name: versionComment
type: string
displayName: Version comment
header: Submission details
{{- end}}

{{/* Patches schema by adding to it and overwriting overlapping fields by the value in metadataAdd*/}}
Expand Down
4 changes: 4 additions & 0 deletions kubernetes/loculus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,10 @@ defaultOrganismConfig: &defaultOrganismConfig
type: percentage
preprocessing:
inputs: {input: nextclade.coverage}
- name: versionComment
type: string
displayName: Version comment
header: Submission details
website: &website
tableColumns:
- sampleCollectionDate
Expand Down
Loading