feat: use 'display name' for the metadata labels on the reviewp. #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chaoran Chen <[email protected]>
…/SequenceEntriesView.kt Co-authored-by: Chaoran Chen <[email protected]>
fhennig
changed the title
|
I'll wait for the #3125 to be merged and then we can merge this one into main afterwards. |
theosanderson
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3116
preview URL:
Summary
The labels for the metadata fields are now using the display names taken from the website config. If no display name is given, the label falls back to the field name (as before).
Screenshot
PR Checklist
All necessary documentation has been adapted.The implemented feature is covered by an appropriate test.